Resolve "[Admin] - Gestion des utilisateurs : éviter que le premier item de la liste soit sélectionné quand on clique sur un champ employeur ou fonction"

Related to #328 (closed)

What does this MR do and why?

MR back : pamn_server!301 (merged)

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally (or on alpha)

List all steps to set up and validate the changes on local environment.

---

MR acceptance checklist

To be completed by the chosen reviewer.

Quality -

• For the code that this change impacts, I believe that the automated tests validate functionality that is highly important to users. If the existing automated tests do not cover this functionality, I have added the necessary additional tests or I have added an issue to describe the automation testing gap and linked it to this MR.
• I have made sure that the sonar quality coverage is up to standards.
• I have considered the impact of this change on the front-end, back-end, and database portions of the system where appropriate and applied.
• I have tested this MR in all supported browsers or determined that this testing is not needed.
• I have confirmed that this change is backwards compatible across updates (migrate up needs a migrate down), or I have decided that this does not apply.

Performance, reliability and availability

• I am confident that this MR does not harm performance, or I have asked a reviewer to help assess the performance impact.
• I have considered the scalability risk based on future predicted growth.

Documentation

• The MR is named after the desired squash commit to feed the changelog linked to the current milestone.
• I have added/updated documentation (also updated if the changes feature a deprecation) or I have decided that documentation changes are not needed for this MR.

Security

• I have confirmed that if this MR does not contains any sensitive informations hidden in the changes.

Related to #328 (closed)

src/app/admin/components/manage-jobs/manage-jobs.component.ts

@@ -23,6 +23,7 @@ export class ManageJobsComponent implements OnInit {
   public validatedJobs: Job[] = [];
   public unvalidatedJobs: Job[] = [];
   public jobsGroups: JobGroup[] = [];
+  public jobsGroupsList: JobGroup[] = [];
   public deleteModalOpened = false;
   public validatedJobsName: string[] = [];
   public mergeJobModalOpened = false;
@@ -264,7 +265,7 @@ export class ManageJobsComponent implements OnInit {
     if (arg.oldValue === arg.newValue) {
       return;
     } else {
-      this.adminService.editJob(arg.data._id, arg.data.name, arg.data.hasPersonalOffer).subscribe(() => {
+      this.adminService.updateJob(arg.data._id, arg.data).subscribe(() => {
         this.notificationService.showSuccess("L'opération a réussie.", '');
         this.findValidatedJobs();
         this.findUnvalidatedJobs();
@@ -348,7 +349,8 @@ export class ManageJobsComponent implements OnInit {
     this.jobsGroupsName = [];
     this.adminService.getJobsGroupsWithJobs().subscribe((jobsGrps) => {
       this.jobsGroups = jobsGrps;
-      jobsGrps.forEach((jobsGroup) => {
+      this.jobsGroupsList = [{ name: '' }, ...jobsGrps];
+      this.jobsGroupsList.forEach((jobsGroup) => {
         this.jobsGroupsName.push(jobsGroup.name);
       });
     });
@@ -390,8 +392,7 @@ export class ManageJobsComponent implements OnInit {
 
   public onJobsGroupChange(arg): void {
     const selectedJob = this.validatedJobs.find((job) => job._id === arg.data._id);
-    const selectedJobsGroup = this.jobsGroups.find((jobsGroup) => jobsGroup.name === arg.newValue);
-
+    const selectedJobsGroup = this.jobsGroupsList.find((jobsGroup) => jobsGroup.name === arg.newValue);
     // The column field is the jobsGroup.name text, we manually assign in selectedJob the full jobsGroup object to be consistent
     selectedJob.jobsGroup = { ...selectedJobsGroup };
 
@@ -399,9 +400,13 @@ export class ManageJobsComponent implements OnInit {
       this.getJobsGroupsWithJobs();
       this.newJobsGroupForm.reset();
 
-      this.notificationService.showSuccess(
-        `Le groupe de fonctions ${selectedJobsGroup.name} a bien été attribuée à la fonction ${arg.data.name}.`
-      );
+      if (selectedJob.jobsGroup?.name === '') {
+        this.notificationService.showSuccess(`Le groupe de fonctions a bien été enlevé.`);
+      } else {
+        this.notificationService.showSuccess(
+          `Le groupe de fonctions ${selectedJobsGroup.name} a bien été attribuée à la fonction ${arg.data.name}.`
+        );
+      }
     });
 
     return;